Skip to content

fix: use the right k8sClient in the repository suite#1797

Merged
Skarlso merged 1 commit into
open-component-model:mainfrom
Skarlso:controller-test-failure
Feb 18, 2026
Merged

fix: use the right k8sClient in the repository suite#1797
Skarlso merged 1 commit into
open-component-model:mainfrom
Skarlso:controller-test-failure

Conversation

@Skarlso

@Skarlso Skarlso commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Looks like the repository suite was using the wrong client. This might not be the entire fix, but certainly is the odd one out.

Fixes https://github.com/open-component-model/open-component-model/actions/runs/22130037921/job/63968085140.

Which issue(s) this PR fixes

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso requested a review from a team as a code owner February 18, 2026 07:18
@github-actions github-actions Bot added kind/bugfix Bug size/xs Extra small labels Feb 18, 2026

@frewilhelm frewilhelm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an idea why this popped up now?

@Skarlso

Skarlso commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

This might not be the root cause. But certainly stands out. It looked like a fluke honestly, but let's see how it goes. I'm still digging deeper though. So I might still find something else too.

So to answer your question, no I don't. :D

@Skarlso

Skarlso commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

Ah, I think I understand now. This was a shared client, and this was simply because of a race between delete and get operation. I got it now.

@Skarlso

Skarlso commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

Basically, this was always broken. :D But we saw it now. :D

@Skarlso Skarlso merged commit cf299bf into open-component-model:main Feb 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix Bug size/xs Extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants