Skip to content

fix: ignore shutdown try if the process is already done#1662

Merged
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
Skarlso:fix-shutdown-race
Jan 26, 2026
Merged

fix: ignore shutdown try if the process is already done#1662
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
Skarlso:fix-shutdown-race

Conversation

@Skarlso

@Skarlso Skarlso commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Shutdown signal can be ignored if the process has already terminated. There is no need to try again.

Test failure: https://github.com/open-component-model/open-component-model/actions/runs/21342586883/job/61424363128#step:7:706

Which issue(s) this PR fixes

@Skarlso Skarlso requested a review from a team as a code owner January 26, 2026 08:36
@github-actions github-actions Bot added kind/bugfix Bug size/xs Extra small labels Jan 26, 2026
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions Bot added the size/s Small label Jan 26, 2026
@Skarlso Skarlso changed the title fix: remove timeout context and use test context fix: ignore shutdown try if the process is already done Jan 26, 2026
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) January 26, 2026 11:47
@jakobmoellerdev jakobmoellerdev merged commit 52a26df into open-component-model:main Jan 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix Bug size/s Small size/xs Extra small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants