Skip to content

feat: migrate the deployment controller to v2#1563

Merged
jakobmoellerdev merged 7 commits into
open-component-model:mainfrom
Skarlso:migrate-deployment-controller
Jan 26, 2026
Merged

feat: migrate the deployment controller to v2#1563
jakobmoellerdev merged 7 commits into
open-component-model:mainfrom
Skarlso:migrate-deployment-controller

Conversation

@Skarlso

@Skarlso Skarlso commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fixes open-component-model/ocm-project#777

Which issue(s) this PR fixes

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Jan 9, 2026
@github-actions github-actions Bot added the size/l Large label Jan 19, 2026
@Skarlso Skarlso marked this pull request as ready for review January 19, 2026 08:30
@Skarlso Skarlso requested a review from a team as a code owner January 19, 2026 08:30
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the migrate-deployment-controller branch from 2f5e8e6 to 9957a20 Compare January 19, 2026 08:31
Comment thread kubernetes/controller/internal/controller/deployer/deployer_controller.go Outdated
@Skarlso Skarlso marked this pull request as draft January 19, 2026 11:31
@Skarlso

Skarlso commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

I'm in the process of cleaning things up and removing left-over OCM code since now everything is using v2. I'll try to remove as much as possible and still keep this PR sane somehow. :)

@jakobmoellerdev

Copy link
Copy Markdown
Member

@Skarlso maybe its wise to merge this PR as is and then follow up with another one. WDYT?

@Skarlso

Skarlso commented Jan 19, 2026

Copy link
Copy Markdown
Contributor Author

@jakobmoellerdev You might be right. I'm over a 1000 changes right now locally. I think I can do that separately. The unused code isn't hurting anything.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso marked this pull request as ready for review January 23, 2026 11:48

@matthiasbruns matthiasbruns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just a small comment

Comment thread kubernetes/controller/internal/controller/deployer/suite_test.go
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) January 26, 2026 15:19
@jakobmoellerdev jakobmoellerdev merged commit 0342183 into open-component-model:main Jan 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2-Migration: Deployer controller

4 participants