fix: pin the kube version for kind in the .env file#1521
Conversation
frewilhelm
left a comment
There was a problem hiding this comment.
we could use https://github.com/open-component-model/open-component-model/blob/main/.env WDYT?
|
@frewilhelm That's not in the controller module. Meaning if I run the task without the root module it doesn't work. |
|
That said, I can't figure out a way for this since Taskfiles doesn't allow nested dotenv. :( |
Maybe we need to move it to the controller then. The envtest version is defined in there as well |
|
Yeah, I'm just going to add something like : this . |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
|
instead of I think you can use |
|
@jakobmoellerdev Root Dir doesn't work if I run the task from under kubernetes/controller. It will try to load the env file from under kubernetes/controller. Relative path works whether I run it from root or from the kubernetes/controller folder. |
|
Relative paths are relative, so they break once you change your calling dir. If there is no parent root dir containing env I believe then you should fail or define a fallback value anyhow. |
|
@jakobmoellerdev I'm sorry, I'm not sure what you mean. :D I'm having a brainfart. Do you mean on the values, something like this: Or do you mean on the ROOT_DIR? And how would ROOT_DIR not exist? Wouldn't it be just |
…th local env On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
|
@jakobmoellerdev okay, I think this is now okay...? |
What this PR does / why we need it
Which issue(s) this PR fixes