fix: make sure correct resource identity type is used#1447
Merged
jakobmoellerdev merged 7 commits intoDec 22, 2025
Merged
Conversation
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
20cf1ba to
e84d9bc
Compare
For external schemas, because we now deduplicate them, we can go ahead and preserve the ID. That will ensure nested definitions are preserved Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
frewilhelm
approved these changes
Dec 22, 2025
piotrjanik
approved these changes
Dec 22, 2025
matthiasbruns
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
makes sure we unify the credential consumer identity for the resource download plugin as well as use the new scheme awareness for it
Which issue(s) this PR fixes
follow up to open-component-model/ocm-project#603