Skip to content

chore(deps): Fix #1429#1432

Merged
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
frewilhelm:fix-1429
Dec 23, 2025
Merged

chore(deps): Fix #1429#1432
jakobmoellerdev merged 2 commits into
open-component-model:mainfrom
frewilhelm:fix-1429

Conversation

@frewilhelm

@frewilhelm frewilhelm commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Supersedes #1429, #1352, #1474, and #1354

@github-actions github-actions Bot added kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/m Medium labels Dec 15, 2025
@frewilhelm frewilhelm marked this pull request as ready for review December 15, 2025 17:38
@frewilhelm frewilhelm requested a review from a team as a code owner December 15, 2025 17:38
@frewilhelm frewilhelm mentioned this pull request Dec 15, 2025
Closed
1 task
@frewilhelm

frewilhelm commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I needed to adjust the localImagePath to get the test running again.

-	localImagePath = "blobs/sha256.4b93359cc643b5d8575d4f96c2d107b4512675dcfee1fa035d0c44a00b9c027c"
+	localImagePath = "blobs/sha256.1bcf96a2451e3d44117d1b31e5bfa15dd326e1393d3434be3e74863ea4f380fc"

Somehow the SHA of the local objects of the component version changed.

Old

total 45112
drwxr-xr-x  6 name group      192 Dec 15 19:07 .
drwx------ 11 name group      352 Dec 15 19:29 ..
-rw-r--r--  1 name group      201 Dec 15 18:09 sha256.16c2d5408d58a716988652737ec2bc0255b2f052e1d880c9f3e41f6c3def61b0
-rw-r--r--  1 name group 46181313 Dec 15 18:09 sha256.4b93359cc643b5d8575d4f96c2d107b4512675dcfee1fa035d0c44a00b9c027c
-rw-r--r--  1 name group     2560 Dec 15 18:09 sha256.76cf0c240312ebc7665ae272ee2ae6d779dd6703caf9382885069c1abe98acf9
-rw-r--r--  1 name group      849 Dec 15 18:09 sha256.96cd6da9be1822f72294d3c41b7d67284209ab8d2a7065f51ac133d42ef652be

New

total 45112
drwxr-xr-x  6 name group      192 Dec 15 19:06 .
drwx------ 13 name group      416 Dec 15 19:29 ..
-rw-r--r--  1 name group 46181312 Dec 15 19:06 sha256.1bcf96a2451e3d44117d1b31e5bfa15dd326e1393d3434be3e74863ea4f380fc
-rw-r--r--  1 name group      201 Dec 15 19:06 sha256.52d9a4ad9ef5fc8c44d34af9a76deeb30abf52a3e38cd2d17ca93d6f55f633cc
-rw-r--r--  1 name group     2560 Dec 15 19:06 sha256.a5562c2f1050684953a07bc8dc94d04a10f46c80b545aa3d2112925a2580eb23
-rw-r--r--  1 name group      849 Dec 15 19:06 sha256.cef06257e27d1ddd31bf1d234af57569e83d0643a11d610f7881c34b8d53d40a

All the SHAs changed and the local image actually lost one byte (46181313 -> 46181312).

The content of the image is the same SHA- and size wise.

A diff of hexdumps from both tars showed this difference:

...
01033ee0  53 f7 fc ce 9d 73 4f fd  ee 99 f9 fe c1 bb 9e f5  |S....sO.........|    01033ee0  53 f7 fc ce 9d 73 4f fd  ee 99 f9 fe c1 bb 9e f5  |S....sO.........|
01033ef0  ec f7 7a 9e b5 7b 51 d5  bd 5f b5 57 15 b8 cf 0e  |..z..{Q.._.W....|    01033ef0  ec f7 7a 9e b5 7b 51 d5  bd 5f b5 17 b8 cf 0e 2d  |..z..{Q.._.....-|
01033f00  2d e7 84 df 46 c7 0a 41  ce bd e2 58 77 a9 08 bb  |-...F..A...Xw...|    01033f00  e7 84 df 46 c7 0a 41 ce  bd e2 58 77 a9 08 bb 07  |...F..A...Xw....|
...

The character W is apparently not part of the new archive (Thanks to @Skarlso for pointing it out).

@jakobmoellerdev

jakobmoellerdev commented Dec 16, 2025

Copy link
Copy Markdown
Member

closing as this is actually an issue in compress

@frewilhelm frewilhelm mentioned this pull request Dec 16, 2025
Closed
9 tasks
@frewilhelm

frewilhelm commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

closing as this is actually an issue in compress

Not yet please because I will need to take care of #1429 (comment) manually

@frewilhelm frewilhelm force-pushed the fix-1429 branch 2 times, most recently from 07a46b8 to 5bdbef3 Compare December 22, 2025 17:31
@frewilhelm

frewilhelm commented Dec 22, 2025

Copy link
Copy Markdown
Contributor Author

compress issues are fixed. I adjusted the PR respectively. However, we needed to bump to ocm v0.34.2 because of the docker update. Thus, we need the replace statement for klauspost/compress v1.18.0.

@frewilhelm
bump dependencies
8569666 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
bump ocm
f7ece0e 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
This was referenced Dec 23, 2025
Closed
Closed
@frewilhelm

frewilhelm commented Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

To address the fulcio bump we upgraded to ocm 0.34.3

@frewilhelm frewilhelm mentioned this pull request Dec 23, 2025
Closed
1 task
@jakobmoellerdev jakobmoellerdev merged commit 1a5876d into open-component-model:main Dec 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frewilhelm @jakobmoellerdev