fix(controller): resource lookup by reference in deployer#1400
Merged
frewilhelm merged 6 commits intoDec 12, 2025
Merged
Conversation
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
jakobmoellerdev
previously approved these changes
Dec 12, 2025
frewilhelm
commented
Dec 12, 2025
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
jakobmoellerdev
approved these changes
Dec 12, 2025
fabianburth
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Currently, the
deployertakes the cv from the resource-status which is a resolved cv if the resource was in a nested cv. However, the resource-reference is taken from the resource-spec. This could still contain thereferencePathto the nested cv. Accordingly, the look-up will fail.Which issue(s) this PR fixes
Fixes #1344