Skip to content

fix: use the latest runtime package to fix the none deterministic failure#1392

Merged
jakobmoellerdev merged 3 commits into
open-component-model:mainfrom
Skarlso:fix-kubernetes-unittest-failure
Dec 10, 2025
Merged

fix: use the latest runtime package to fix the none deterministic failure#1392
jakobmoellerdev merged 3 commits into
open-component-model:mainfrom
Skarlso:fix-kubernetes-unittest-failure

Conversation

@Skarlso

@Skarlso Skarlso commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Fix the runner: https://github.com/open-component-model/open-component-model/actions/runs/20093305963/job/57645974622

Which issue(s) this PR fixes

@Skarlso Skarlso requested a review from a team as a code owner December 10, 2025 10:53
@Skarlso Skarlso force-pushed the fix-kubernetes-unittest-failure branch from 8a4d2aa to 2353524 Compare December 10, 2025 11:02
Comment thread kubernetes/controller/internal/configuration/config.go
@Skarlso Skarlso force-pushed the fix-kubernetes-unittest-failure branch 2 times, most recently from a7433c8 to edadff9 Compare December 10, 2025 11:27
@Skarlso

Skarlso commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

This will be fixed once there is a new version of the runtime module. The original had the type default as a map so ranging through that was undeterministic. Which means, sometimes we got the one with the version and something without.

On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the fix-kubernetes-unittest-failure branch from edadff9 to 2f37f46 Compare December 10, 2025 11:38
@Skarlso Skarlso changed the title fix: use a clean scheme for the conversion logic fix: use the latest runtime package to fix the none deterministic failure Dec 10, 2025
Skarlso and others added 2 commits December 10, 2025 13:12
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@jakobmoellerdev jakobmoellerdev merged commit 758d8f0 into open-component-model:main Dec 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants