fix: rm nested fields and descriptor scheme#1391
Merged
jakobmoellerdev merged 4 commits intoDec 11, 2025
Merged
Conversation
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
Signed-off-by: Jakob Möller <contact@jakob-moeller.com>
frewilhelm
approved these changes
Dec 10, 2025
piotrjanik
reviewed
Dec 10, 2025
fabianburth
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
this makes it so that we can override the scheme that is used and referenced for a type with an annotation. we use this for descriptor v2 to embed the descriptor scheme which (for now) is pregenerated and maintained manually instead of autogenerated.
It also removes nested ids to embed the schemes properly so that they are considered part of their parent scheme and def resolution works as we intended it.
Which issue(s) this PR fixes