fix(oci): update dependencies to simplified plugin registration#1325
Merged
jakobmoellerdev merged 9 commits intoDec 3, 2025
Conversation
6dcad68 to
d349ea8
Compare
frewilhelm
reviewed
Dec 3, 2025
frewilhelm
reviewed
Dec 3, 2025
Comment on lines
+166
to
+167
| repospec.MustAddToScheme(scheme) | ||
| repospec.MustAddLegacyToScheme(scheme) |
Contributor
There was a problem hiding this comment.
This won't work, see #1284
Thats why we added it previously so cumbersome:
repositoryScheme.MustRegisterWithAlias(&ociv1.Repository{},
runtime.NewVersionedType(ociv1.Type, ociv1.Version),
runtime.NewUnversionedType(ociv1.Type),
runtime.NewVersionedType(ociv1.ShortType, ociv1.Version),
runtime.NewUnversionedType(ociv1.ShortType),
runtime.NewVersionedType(ociv1.ShortType2, ociv1.Version),
runtime.NewUnversionedType(ociv1.ShortType2),
runtime.NewVersionedType(ociv1.LegacyRegistryType, ociv1.Version),
runtime.NewUnversionedType(ociv1.LegacyRegistryType),
runtime.NewVersionedType(ociv1.LegacyRegistryType2, ociv1.Version),
runtime.NewUnversionedType(ociv1.LegacyRegistryType2),
)
Contributor
There was a problem hiding this comment.
we probably need that too for the unit-tests, e.g. in suite_test.go if we will add compatibility tests at some point. that's why I created Register function in plugins before
Contributor
Author
There was a problem hiding this comment.
i guess now it worked because the tests consistently use the legacy type and i happened to be calling the legacy type registration later
Contributor
Author
There was a problem hiding this comment.
I hope now it is fixed
frewilhelm
previously approved these changes
Dec 3, 2025
jakobmoellerdev
previously approved these changes
Dec 3, 2025
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Updated the internal registration of signing and credential repository plugins to ensure proper functionality and error handling. This includes adjustments to the signature algorithm handling and the registration process for the new plugins. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
a855fe5
72459ab to
a855fe5
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Contributes to open-component-model/ocm-project#761