Skip to content

chore(deps): update helm plugin to refactored plugin manager#1315

Merged
fabianburth merged 9 commits into
open-component-model:mainfrom
fabianburth:chore/update-helm-plugin-dep
Dec 2, 2025
Merged

chore(deps): update helm plugin to refactored plugin manager#1315
fabianburth merged 9 commits into
open-component-model:mainfrom
fabianburth:chore/update-helm-plugin-dep

Conversation

@fabianburth

@fabianburth fabianburth commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

During the plugin manager refactoring, constants were moved to different packages. This updates the helm plugin to import the updated packages.

Notes for the Reviewer
I couldn't update the runtime module to 0.0.4 yet, as the plugin module will have to be updated to the JSON schema generator introduced here.

Which issue(s) this PR fixes

Contributes to open-component-model/ocm-project#760

@fabianburth
chore(deps): update helm plugin to refactored plugin manager
e27e128 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth fabianburth requested a review from a team as a code owner December 1, 2025 09:22
@github-actions github-actions Bot added kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/s Small labels Dec 1, 2025
@fabianburth
chore(helm): adjust capability test to updated plugin module
d3e8d3e 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
jakobmoellerdev
jakobmoellerdev previously approved these changes Dec 1, 2025
View reviewed changes
matthiasbruns
matthiasbruns previously approved these changes Dec 2, 2025
View reviewed changes
@gitguardian

gitguardian Bot commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Skarlso
Skarlso reviewed Dec 2, 2025
View reviewed changes
Comment thread bindings/go/helm/cmd/main_test.go Outdated
Skarlso
Skarlso reviewed Dec 2, 2025
View reviewed changes

@Skarlso Skarlso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from import ordering. :)

@fabianburth
chore(test): update plugin runtime import in main_test.go
557c0d3 
Refactor the import statement for the plugin runtime to align with the new module structure.

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth
Merge remote-tracking branch 'fabianburth/chore/update-helm-plugin-de…
5ef310b 
…p' into chore/update-helm-plugin-dep
@fabianburth

fabianburth commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

LGTM apart from import ordering. :)

linter does not care about test files

Skarlso
Skarlso previously approved these changes Dec 2, 2025
View reviewed changes

@Skarlso Skarlso left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're right.

@fabianburth fabianburth enabled auto-merge (squash) December 2, 2025 10:04
@fabianburth
Merge branch 'main' into chore/update-helm-plugin-dep
00b8d0f 
# Conflicts:
#	bindings/go/helm/go.mod
#	bindings/go/helm/go.sum
@fabianburth
chore(helm): update go mod
656f62a 
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@github-actions github-actions Bot added the size/m Medium label Dec 2, 2025
@fabianburth fabianburth merged commit 0c8ad3c into open-component-model:main Dec 2, 2025
19 checks passed
@fabianburth fabianburth deleted the chore/update-helm-plugin-dep branch December 2, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

@matthiasbruns matthiasbruns matthiasbruns left review comments

Assignees

No one assigned

Labels

kind/chore chore, maintenance, etc. kind/dependency dependency update, etc. size/m Medium size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabianburth @Skarlso @matthiasbruns @jakobmoellerdev