chore: Fix Deepcopy issue for Component struct#1266
Merged
jakobmoellerdev merged 12 commits intoDec 3, 2025
Merged
Conversation
7 tasks
fac50f9 to
af1f5a5
Compare
ea21acb to
c2e8290
Compare
ecfe3f8 to
c2e8290
Compare
…ests for both On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
matthiasbruns
previously approved these changes
Nov 28, 2025
piotrjanik
reviewed
Nov 28, 2025
On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…-component-model into issue-762/enable-deepcopy On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
matthiasbruns
previously approved these changes
Dec 2, 2025
Contributor
|
This looks like it's working Gerald? What was all the fuss about? :D |
Skarlso
previously approved these changes
Dec 2, 2025
fabianburth
requested changes
Dec 2, 2025
…epcopy On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
Contributor
Author
I really don't have an explanation why it didn't work when we set the annotation for the first time. Fabian tried it and had no success and so did I. This is why the issue was created at first place. After seeing it does not work, I started to come up with options. Then before implementing the option we decided on, I just tried out setting the annotations again and then it worked. And no, the version of deepcopy-gen did not change between the trials. X-mas magic 😉 |
On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
…-component-model into issue-762/enable-deepcopy On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
jakobmoellerdev
approved these changes
Dec 3, 2025
fabianburth
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: Gerald Morrison (SAP) gerald.morrison@sap.com
What this PR does / why we need it
Fix Deepcopy issue for Component struct