fix: add subPath to OCI repository spec implementation - bindings#1235
Merged
piotrjanik merged 4 commits intoNov 24, 2025
Merged
Conversation
What this PR does / why we need it: The OCM specification defines an optional subPath field as a repository prefix. As this field is missing in the current ocm v2. Which issue(s) this PR fixes: open-component-model/ocm-project#756 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
fabianburth
reviewed
Nov 21, 2025
fabianburth
left a comment
Contributor
There was a problem hiding this comment.
Generally, looks good. Just for my understanding, so our implementations essentially does not care about whether you split your url into baseUrl and subPath or whether you just put everything into baseUrl?
fabianburth
previously approved these changes
Nov 21, 2025
What this PR does / why we need it: The OCM specification defines an optional subPath field as a repository prefix. As this field is missing in the current ocm v2. Which issue(s) this PR fixes: open-component-model/ocm-project#756 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
fd4535e
What this PR does / why we need it: The OCM specification defines an optional subPath field as a repository prefix. As this field is missing in the current ocm v2. Which issue(s) this PR fixes: open-component-model/ocm-project#756 Signed-off-by: Piotr Janik <piotr.janik@sap.com>
jakobmoellerdev
approved these changes
Nov 24, 2025
fabianburth
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The OCM specification defines an optional subPath field as a repository prefix. As this field is missing in the current ocm v2.
Which issue(s) this PR fixes:
open-component-model/ocm-project#756