Skip to content

feat: Add command to manage plugins#1190

Merged
jakobmoellerdev merged 35 commits into
open-component-model:mainfrom
frewilhelm:manage-plugins-for-registry
Nov 19, 2025
Merged

feat: Add command to manage plugins#1190
jakobmoellerdev merged 35 commits into
open-component-model:mainfrom
frewilhelm:manage-plugins-for-registry

Conversation

@frewilhelm

@frewilhelm frewilhelm commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the size/s Small label Nov 11, 2025
@frewilhelm frewilhelm changed the title Add command to manage plugins feat: Add command to manage plugins Nov 11, 2025
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium size/l Large labels Nov 11, 2025
@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from c08ea67 to 2332971 Compare November 13, 2025 18:50
jakobmoellerdev
jakobmoellerdev reviewed Nov 13, 2025
View reviewed changes

@jakobmoellerdev jakobmoellerdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, really mostly style comments. good stuff :)

Comment thread cli/cmd/plugins/list/cmd.go Outdated
Comment thread cli/cmd/plugins/list/cmd.go Outdated
Comment thread cli/cmd/plugins/list/cmd.go Outdated
Comment thread cli/cmd/plugins/list/cmd.go
Comment thread cli/cmd/plugins/list/cmd.go Outdated
Comment thread cli/docs/reference/ocm_plugin_registry_list.md Outdated
@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from 6c475b2 to 574d60a Compare November 14, 2025 22:03
@frewilhelm frewilhelm marked this pull request as ready for review November 14, 2025 22:03
@frewilhelm frewilhelm requested a review from a team as a code owner November 14, 2025 22:03
jakobmoellerdev
jakobmoellerdev reviewed Nov 14, 2025
View reviewed changes

@jakobmoellerdev jakobmoellerdev left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from small linters good stuff. thanks for your hard work on this ❤️ (just cd into the integration test dir and run go mod tidy, should clean you up)

@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from 6df6072 to cebb7e0 Compare November 17, 2025 08:10
@frewilhelm

frewilhelm commented Nov 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

just cd into the integration test dir and run go mod tidy, should clean you up

nope, did not help. I also tried executing the commands recommended by golangci-lint which made it even worse :D

@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from 88afd67 to 9ab1a97 Compare November 17, 2025 08:17
@jakobmoellerdev

jakobmoellerdev commented Nov 17, 2025

Copy link
Copy Markdown
Member

/home/runner/work/open-component-model/open-component-model/cli/integration/internal/plugins.go:7:2: could not import ocm.software/open-component-model/cli/cmd/plugins/list (internal/plugins.go:7:2: no required module provides package ocm.software/open-component-model/cli/cmd/plugins/list; Please check your go module structure.

@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from 881c927 to 7e1c055 Compare November 17, 2025 10:43
Skarlso
Skarlso reviewed Nov 17, 2025
View reviewed changes
Comment thread cli/cmd/plugins/list/cmd.go Outdated
@github-actions github-actions Bot added the component/github-actions Changes on GitHub Actions or within `.github/` directory label Nov 17, 2025
Skarlso
Skarlso reviewed Nov 17, 2025
View reviewed changes
Comment thread cli/cmd/plugins/list/cmd.go Outdated
Skarlso
Skarlso reviewed Nov 17, 2025
View reviewed changes
Comment thread cli/cmd/plugins/list/cmd.go
@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from c9a84f0 to d151a6f Compare November 17, 2025 12:29
@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch 6 times, most recently from 65edf96 to d3e9d94 Compare November 17, 2025 14:17
@frewilhelm
adjust the expected labels from the component references
3883991 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
add plugin manager get command
672ebf1 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
refactor plugin manager list
74def12 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
nit refactoring
1e67e31 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
linter issues
beac3fc 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
introduce 'wide' option
f448598 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
linter & nits
2e8b0f1 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
fix bug where component name was not stored
e17bc6c 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
fix error messages
502c14e 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
ignore defer-error
3c93829 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
add new output option to docs
0505e30 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
update dependency
0dda0f5 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
add version resolver to latest for plugin registry
61b9d53 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
pass values instead of struct (resolve some weird golangci-lint issue)
8d663c5 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
bump golangci-lint version
3e6c68f 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
preliminary fix of new golangci-lint issues
9a6b0c7 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
fix length check
c5727c3 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
fix module structure
598a4b4 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
error if plugin is not found
1c7c1da 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
fix error testing
fba8a77 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
add label key as constant
b0136e6 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm
put functions into test file to satisfy linter
fd28529 
Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com>
@frewilhelm frewilhelm force-pushed the manage-plugins-for-registry branch from facc9c6 to fd28529 Compare November 19, 2025 07:46
matthiasbruns
matthiasbruns approved these changes Nov 19, 2025
View reviewed changes

@matthiasbruns matthiasbruns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work there

@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) November 19, 2025 09:48
@jakobmoellerdev jakobmoellerdev merged commit f2e82e0 into open-component-model:main Nov 19, 2025
39 checks passed
@frewilhelm frewilhelm mentioned this pull request Nov 19, 2025
Open
9 tasks
@frewilhelm frewilhelm deleted the manage-plugins-for-registry branch November 19, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@matthiasbruns matthiasbruns matthiasbruns approved these changes

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

Assignees

No one assigned

Labels

component/github-actions Changes on GitHub Actions or within `.github/` directory kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium size/s Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Manage plugins for a plugin registry

4 participants

@frewilhelm @jakobmoellerdev @Skarlso @matthiasbruns