feat(697): recursive cleanup#1076
Merged
matthiasbruns merged 13 commits intoOct 31, 2025
Merged
Conversation
matthiasbruns
commented
Oct 23, 2025
matthiasbruns
commented
Oct 23, 2025
8f31a11 to
9e17cff
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
9e17cff to
c1acaed
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
this looks okay I think, just want a second pair of eyes on the resolver sources again
cli/internal/repository/ocm/compatibility.go conflicts with https://github.com/open-component-model/open-component-model/pull/1068/files#diff-663659045698232a0fff6c41b0e3d09d9db13b64fb711264e0c9132edf2fc1f8 so maybe align here before we proceed
Contributor
Author
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
…/open-component-model into feat/697_recursive_cleanup
matthiasbruns
commented
Oct 30, 2025
7dfdf7d to
ec787d4
Compare
jakobmoellerdev
left a comment
Member
There was a problem hiding this comment.
this is pretty much LGTM, just 2 minor comments from my side
Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
jakobmoellerdev
approved these changes
Oct 31, 2025
fabianburth
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pr unifies the dependency graph calculation in the cli.
Which issue(s) this PR fixes
Contributes: open-component-model/ocm-project#697