Skip to content

feat: ocm get cv <ctf_dir>#1068

Merged
jakobmoellerdev merged 32 commits into
open-component-model:mainfrom
ikhandamirov:comp-list-cli-get-cv
Oct 31, 2025
Merged

feat: ocm get cv <ctf_dir>#1068
jakobmoellerdev merged 32 commits into
open-component-model:mainfrom
ikhandamirov:comp-list-cli-get-cv

Conversation

@ikhandamirov

@ikhandamirov ikhandamirov commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

With this PR the OCM CLI will support ocm get cv <ctf_dir> command.

Which issue(s) this PR fixes

Contributes to open-component-model/ocm-project#675

@ikhandamirov
init
8706a40 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Oct 20, 2025
@ikhandamirov

ikhandamirov commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@piotrjanik, this is the the initial version we were talking about today. It runs end-to-end, but the output is ugly, the whole thing needs some refactoring.

At the moment, if component name or component name and version are provided, everything runs as before. If only the path to a dir is provided, a list of components is retrieved first, then the "old" processing is done per component. The latter needs to be changed.

@ikhandamirov
call renderComponents() only once
d051e6a 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
separate exec line for repo refs
02d015c 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
linting
89179f3 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
rename matching func
ef632ca 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
VersionsWithFiltering() instead of GetComponentVersions
fbedb0f 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
now with renderComponents()
ddcdb8f 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
linting
ce4631c 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov
tests
bb22bd7 
Signed-off-by: Ilya Khandamirov <ilya.khandamirov@sap.com>
@ikhandamirov ikhandamirov marked this pull request as ready for review October 23, 2025 15:42
@ikhandamirov ikhandamirov requested a review from a team as a code owner October 23, 2025 15:42
piotrjanik
piotrjanik reviewed Oct 27, 2025
View reviewed changes
Comment thread cli/cmd/get/component-version/cmd.go Outdated
Comment thread cli/cmd/get/component-version/cmd.go Outdated
Comment thread cli/cmd/get/component-version/cmd.go Outdated
piotrjanik
piotrjanik reviewed Oct 28, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
Skarlso
Skarlso reviewed Oct 28, 2025
View reviewed changes
Comment thread cli/cmd/get/component-version/cmd.go
@Skarlso
unify the another function as much as possible
93fc6b8 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso

Skarlso commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

I refactored the New function, please take a look at it.

jakobmoellerdev
jakobmoellerdev reviewed Oct 29, 2025
View reviewed changes
Comment thread cli/cmd/get/component-version/cmd.go
Comment thread cli/cmd/get/component-version/cmd.go
Comment thread cli/cmd/get/component-version/cmd.go Outdated
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
Comment thread cli/internal/repository/ocm/compatibility.go
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
piotrjanik
piotrjanik reviewed Oct 29, 2025
View reviewed changes
Comment thread cli/cmd/cmd_test.go
Comment thread cli/cmd/cmd_test.go
piotrjanik
piotrjanik reviewed Oct 29, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
matthiasbruns
matthiasbruns reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
@github-actions github-actions Bot added the size/l Large label Oct 30, 2025
matthiasbruns
matthiasbruns reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go
Skarlso
Skarlso reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/list.go Outdated
Skarlso
Skarlso reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/list.go Outdated
Skarlso
Skarlso reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/compatibility.go Outdated
Skarlso
Skarlso reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/list.go
Skarlso
Skarlso reviewed Oct 30, 2025
View reviewed changes
Comment thread cli/internal/repository/ocm/list.go Outdated
@piotrjanik piotrjanik force-pushed the comp-list-cli-get-cv branch from b793966 to bc5d82f Compare October 30, 2025 22:56
piotrjanik and others added 15 commits October 31, 2025 00:34
@piotrjanik
improve logging levels for component version commands
848d5ba 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@Skarlso @piotrjanik
remove redundant function call
f4d4b45 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@piotrjanik
update comments compatibility.go to clarify behavior when both conf…
2cd64b5 
…iguration types are set simultaneously

Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
lower case componentOrRepositoryReferenceAsFirstPositional
e1c712b 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
Refactor component version querying in CLI by introducing a reusable …
4336ad2 
…`ListComponentVersions` function in the OCM repository package that supports filtering and sorting.

Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
Refactors component repository provider creation
fd046f9 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
Refactors component repository provider creation
1966123 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
style: remove unnecessary blank lines in ocm package
1c54cea 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
Removed redundant test assertions
c2a773f 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
proper sorting
14c77b7 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
comment fix
da831d7 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
test cases for listing component
d0120ce 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
find the latest version before getting cv
e7d3c85 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
test case scenario no versions found
ae9f2c0 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik
test case scenario no versions found
8ae962b 
Signed-off-by: Piotr Janik <piotr.janik@sap.com>
@piotrjanik piotrjanik force-pushed the comp-list-cli-get-cv branch from 01c2341 to 8ae962b Compare October 30, 2025 23:35
@Skarlso
improve list parsing to return errors in case of invalid semver versions
a22fd30 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
error if there are no components in a given repository
4c696fa 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Skarlso
Skarlso reviewed Oct 31, 2025
View reviewed changes
Comment thread cli/cmd/get/component-version/cmd.go
Skarlso and others added 2 commits October 31, 2025 07:57
@Skarlso
added test for no component versions in repository
eadc072 
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Merge branch 'main' into comp-list-cli-get-cv
9796c51
Skarlso
Skarlso approved these changes Oct 31, 2025
View reviewed changes

@Skarlso Skarlso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakobmoellerdev jakobmoellerdev merged commit d60ed0b into open-component-model:main Oct 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotrjanik piotrjanik piotrjanik left review comments

@matthiasbruns matthiasbruns matthiasbruns left review comments

@fabianburth fabianburth fabianburth left review comments

@Skarlso Skarlso Skarlso approved these changes

@jakobmoellerdev jakobmoellerdev jakobmoellerdev approved these changes

Assignees

No one assigned

Labels

kind/feature new feature, enhancement, improvement, extension size/l Large size/m Medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ikhandamirov @Skarlso @piotrjanik @matthiasbruns @fabianburth @jakobmoellerdev