docs(adr): ADR to unify constructors and transformations#1041
Merged
Skarlso merged 34 commits intoNov 13, 2025
Merged
Conversation
fce00f3 to
c05733d
Compare
7 tasks
fd6ca8f to
42c16a4
Compare
258ecbf to
089e455
Compare
piotrjanik
reviewed
Oct 16, 2025
piotrjanik
reviewed
Oct 16, 2025
Introduce ADR0012 specifying a OCM transformation specification that treats component constructors as a form of transformation. Document the motivation, requirements comparison, and solution: generate a transformation spec from existing constructor files to preserve the current constructor workflow while enabling `ocm transfer component`-style operations and easing the transition to ocm v2. Key changes: - Add new ADR detailing context, problem statement, and proposed solution. - Compare transfer vs constructor requirements and conclude they are functionally equivalent. - Provide an example constructor and the generated transformation specification (partial) to illustrate the conversion approach. This clarifies design decisions, aligns transformations and constructors, and lays groundwork for generating transformation specs from constructor files. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
b00229e to
478822f
Compare
Skarlso
reviewed
Oct 20, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Couple of questions really and one/two improvement requests.
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Added a note indicating that the program flow section will be updated as the implementation progresses, referencing the Builder implementation of KRO for inspiration. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
7 tasks
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
…rototype Signed-off-by: Fabian Burth <fabian.burth@sap.com>
…citly as non goal Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Skarlso
previously approved these changes
Nov 13, 2025
Skarlso
left a comment
Contributor
There was a problem hiding this comment.
Alright, let's get this thing on the road!
morri-son
previously approved these changes
Nov 13, 2025
morri-son
left a comment
Contributor
There was a problem hiding this comment.
lgtm already. My requested changes were just correcting formatting issues.
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
…truct' into adr-unify-transfer-and-construct
Skarlso
approved these changes
Nov 13, 2025
jakobmoellerdev
approved these changes
Nov 13, 2025
Contributor
|
@matthiasbruns good ideas with the graphs, but for now, we are going to skip those in favor of progress basically. The ADR is HUGE as is. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Introduce ADR0012 specifying a OCM transformation specification that treats component constructors as a form of transformation. Document the motivation, requirements comparison, and solution: generate a transformation spec from existing constructor files to preserve the current constructor workflow while enabling
ocm transfer component-style operations and easing the transition to ocm v2.Key changes:
This clarifies design decisions, aligns transformations and constructors, and lays groundwork for generating transformation specs from constructor files.
Which issue(s) this PR fixes
open-component-model/ocm-project#719