Skip to content

feat: add component construction with external references#1009

Merged
jakobmoellerdev merged 6 commits into
open-component-model:mainfrom
jakobmoellerdev:construct-copy-ref
Oct 9, 2025
Merged

feat: add component construction with external references#1009
jakobmoellerdev merged 6 commits into
open-component-model:mainfrom
jakobmoellerdev:construct-copy-ref

Conversation

@jakobmoellerdev

@jakobmoellerdev jakobmoellerdev commented Oct 7, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it

adds a test for add cv using recursion to external components leveraging our resolvers.

Which issue(s) this PR fixes

fix open-component-model/ocm-project#666

Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>

# Conflicts:
#	cli/go.mod
#	cli/go.sum
@github-actions github-actions Bot added kind/chore chore, maintenance, etc. size/m Medium labels Oct 7, 2025
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review October 7, 2025 14:16
@jakobmoellerdev jakobmoellerdev requested a review from a team as a code owner October 7, 2025 14:16
@jakobmoellerdev jakobmoellerdev changed the title chore: add component construction tests with external references feat: add component construction with external references Oct 7, 2025
@github-actions github-actions Bot added the kind/feature new feature, enhancement, improvement, extension label Oct 7, 2025
…rences

this allows to turn on or off external reference copying in the constructor. we can use this for example in CLI by binding this to `--recursive` which will enable or disable copying of external component versions

Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Comment thread cli/cmd/cmd_test.go Outdated
Comment thread cli/cmd/cmd_test.go
Comment thread cli/cmd/add/component-version/cmd.go
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
@jakobmoellerdev jakobmoellerdev enabled auto-merge (squash) October 9, 2025 11:29
@jakobmoellerdev jakobmoellerdev merged commit 893e1e5 into open-component-model:main Oct 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/chore chore, maintenance, etc. kind/feature new feature, enhancement, improvement, extension size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support for --recursive for add componentversion

3 participants