Skip to content

Update oci bindings to work with typed credentials #986

@matthiasbruns

Description

@matthiasbruns

Description

We currently rely on these consts to access and store credential values

// CredentialKey constants define the standard keys used in credential maps.
// These keys are used to store and retrieve different types of credentials.
const (
	// CredentialKeyUsername is the key for storing username credentials
	CredentialKeyUsername = "username"
	// CredentialKeyPassword is the key for storing password credentials
	CredentialKeyPassword = "password"
	// CredentialKeyAccessToken is the key for storing access token credentials
	CredentialKeyAccessToken = "accessToken"
	// CredentialKeyRefreshToken is the key for storing refresh token credentials
	CredentialKeyRefreshToken = "refreshToken"
)

Those will need to become its own spec within the oci bindings.

You can find the current scheme in here: bindings/go/oci/spec/credentials/v1

We also need to update the incoming credentials structure from map[string]string to runtime.Typed

AC

  • Credentials for oci like Docker/

Done Criteria

  • replace key-map access with proper scheme/spec access and parsing
  • replace map[string]string credentials with runtime.Typed in bindings/oci
  • Verify that we have all oci credentials as typed scheme
  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Internal technical Documentation created/updated (if applicable)
  • Successful demonstration in Review

Metadata

Metadata

Assignees

Labels

area/ipceiImportant Project of Common European Interestkind/tasksmall task, normally part of feature or epic

Type

No fields configured for Task.

Projects

Status
🍺 Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions