Skip to content

Move component verification to resolution service #787

@frewilhelm

Description

@frewilhelm

Description

Currently, in the ocm-controllers (v2) the resolution service only caches component versions. The verification is done in the component controller. However, since the resource and deployer controller also need a verified component version, we should move the component verification to the resolution service and only add them to the cache if they are verified (if a signature to verify was passed of course).

This can affect the reconciliation time.

Check out https://github.com/open-component-model/open-component-model/blob/main/docs/adr/0009_controller_v2_lib_migration.md

Done Criteria

  • Also consider to change the field name from Verify to Signatures (check out subfields)
  • Extract the component verification from the component-controller to the resolution service
  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Internal technical Documentation created/updated (if applicable)
  • Successful demonstration in Review

Metadata

Metadata

Labels

area/ipceiImportant Project of Common European Interestkind/tasksmall task, normally part of feature or epic

Type

No fields configured for Bug.

Projects

Status
🍺 Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions