Skip to content

Replace tarDirectoryRecursive with built-in filesystem.GetBlobFromPath #1014

@matthiasbruns

Description

@matthiasbruns

Description

In https://github.com/open-component-model/open-component-model/blob/d134f52155dcc1f25829cd1fff01cac5bd7aa5a6/bindings/go/helm/repository/resource/resource_repository.go#L118 we added a helper method that walks the downloaded dir and tars a helm chart and prov file.

This should actually be doable with filesystem.GetBlobFromPath (https://github.com/open-component-model/open-component-model/blob/1062fdf73fd4724133ca0fe0c81b5a9e58ff1f39/bindings/go/blob/filesystem/blob_from_path.go#L52)

After testing for several hours, we decided to do this at a later stage.
The problem seems to be that GetBlobFromPath works async with Pipes, but our tarReader that later accesses the blob, cannot handle this correctly.

Done Criteria

  • Provide a way to sync-read from GetBlobFromPath or fix the tar-reader to be able to handle the direct blob
  • Code has been reviewed by other team members
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Internal technical Documentation created/updated (if applicable)
  • Successful demonstration in Review

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/ipceiImportant Project of Common European Interestkind/tasksmall task, normally part of feature or epic

    Type

    No fields configured for Task.

    Projects

    Status
    🛠️ Needs Refinement

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions