Skip to content

Don't set up more than 1 abort signal listener #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gustavohenke merged 1 commit into from
Sep 12, 2024
Merged

Don't set up more than 1 abort signal listener #503

gustavohenke merged 1 commit into from
Sep 12, 2024

Conversation

@gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented Sep 9, 2024

🤦 Rxjs' fromEvent creates a new listener on every subscription, but this is a bit hidden because the abort signal isn't subscribed to directly:

concurrently/src/completion-listener.ts

Lines 96 to 109 in a7a5894

const abort =
abortSignal &&
Rx.fromEvent(abortSignal, 'abort', { once: true }).pipe(
// The abort signal must happen before commands are killed, otherwise new commands
// might spawn. Because of this, it's not be possible to capture the close events
// without an immediate delay
delay(0, this.scheduler),
map(() => undefined),
);
const closeStreams = commands.map((command) =>
abort
? // Commands that have been started must close.
Rx.race(command.close, abort.pipe(filter(() => command.state === 'stopped')))

Sounds like just sharing the underlying source observable is enough.

Fixes #502

@gustavohenke gustavohenke mentioned this pull request Sep 9, 2024
Closed
@coveralls
Copy link

coveralls commented Sep 9, 2024

Coverage Status

coverage: 98.263%. remained the same
when pulling 74cc2f2 on abortsignal-leak
into a7a5894 on main.

@gustavohenke gustavohenke merged commit 041520b into main Sep 12, 2024
@gustavohenke gustavohenke deleted the abortsignal-leak branch September 12, 2024 00:39
@renovate renovate bot mentioned this pull request Sep 23, 2024
Closed
1 task
@Rosenstein Rosenstein mentioned this pull request Oct 3, 2024
Open
@renovate renovate bot mentioned this pull request Oct 6, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Jul 2, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node emits MaxListenersExceededWarning with v9.0.0

3 participants

@gustavohenke @coveralls