Conversation
Add a --link flag to the nrql and entities search commands that generates clickable New Relic deep link URLs. For nrql: when --link is passed, outputs a URL that opens the query builder with the query pre-populated and auto-executed, instead of running the query. For entities search: when --link is passed, includes an entity redirect URL for each result in the output.
- Handle json.Marshal error instead of discarding it - Use url.Values for consistent URL query parameter encoding - URL-encode entity GUIDs with url.PathEscape to prevent path traversal from base64 special characters (/, ?, #) - Move --link check before APIClient() so deep links only require an account ID, not a configured API key - Add edge-case tests for unicode, newlines, and base64 special characters in GUIDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--linkflag tonrq nrqlcommand that generates a New Relic query builder deep link URL instead of executing the query. The URL opens the query builder with the NRQL query pre-populated and auto-executed.--linkflag tonrq entities searchcommand that includes a New Relic entity redirect URL for each entity in the output.Usage
The
--linkflag also works with thenrql querysubcommand and composes with--since/--untilflags.Test plan
go build ./...passesgo test ./...passesnrq nrql --link "SELECT 1"outputs a valid URLnrq entities search "domain = 'APM'" --linkincludes LINK column