-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: remove error re-exports in jtk #22
Copy link
Copy link
Closed
Description
Summary
Remove unnecessary error re-exports in jtk's API package - callers can import the shared errors package directly.
Current State
tools/jtk/api/errors.go re-exports shared errors:
var (
ErrNotFound = sharederrors.ErrNotFound
ErrUnauthorized = sharederrors.ErrUnauthorized
ErrForbidden = sharederrors.ErrForbidden
ErrBadRequest = sharederrors.ErrBadRequest
ErrServerError = sharederrors.ErrServerError
ErrRateLimited = sharederrors.ErrRateLimited
)
func IsNotFound(err error) bool {
return sharederrors.IsNotFound(err)
}
func IsUnauthorized(err error) bool {
return sharederrors.IsUnauthorized(err)
}
func IsRateLimited(err error) bool {
return sharederrors.IsRateLimited(err)
}Proposed Changes
- Remove re-exported error variables and functions
- Keep only tool-specific errors:
ErrIssueKeyRequired,ErrProjectKeyRequired - Update callers to import
github.com/open-cli-collective/atlassian-go/errorsdirectly
Impact
~20 lines removed, 1 file changed, callers updated to use shared package
Benefits
- Less indirection
- Clearer dependency on shared package
- Easier to maintain
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels