Skip to content

feat(i18n): add Japanese translations#431

Merged
fabian-hiller merged 7 commits intoopen-circle:mainfrom
roottool:feat-i18n-ja
Feb 11, 2024
Merged

feat(i18n): add Japanese translations#431
fabian-hiller merged 7 commits intoopen-circle:mainfrom
roottool:feat-i18n-ja

Conversation

@roottool
Copy link
Copy Markdown
Contributor

Add Japanese for @valibot/i18n

@fabian-hiller
Copy link
Copy Markdown
Member

Thank you for this PR! Do you know another native speaking developer that could review the translations for me?

@fabian-hiller fabian-hiller self-assigned this Feb 10, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Feb 10, 2024
@t6adev
Copy link
Copy Markdown

t6adev commented Feb 10, 2024

There are no weird translations so it would be approved IMO 👏

Copy link
Copy Markdown
Contributor

@chimame chimame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for leaving the review prematurely.
There are some parts that I forgot to ask for corrections. How about fixing it like this?

@shossk
Copy link
Copy Markdown

shossk commented Feb 10, 2024

少し細かいニュアンスを含むので日本語でコメント失礼します。

「期待したが」「期待しましたが」よりも「期待されましたが」の方が主観的ではなく客観的な意味合いを含むためルールを元にしたエラーメッセージには適していると考えます。

「期待されましたが」: この表現では、何らかの標準、ルール、外部の期待に基づく客観的な視点を暗示します。例えば、システムやプロトコルが特定の形式やデータ型を要求している場合に適します。

「期待したが」: こちらはより主観的な視点を含みます。特定の個人やグループが特定の結果や反応を予想していたことを示します。この変更により、期待がより個人的なもの、または特定の集団によるものであるかのような印象を与えます。

@chimame
Copy link
Copy Markdown
Contributor

chimame commented Feb 10, 2024

@roottool Thank you for the correction. 👍
We hope that valibot will be used because error messages can now be displayed in Japanese.

@fabian-hiller
Copy link
Copy Markdown
Member

Thank you all very much! @roottool do you think this PR is ready to be merged now?

@roottool
Copy link
Copy Markdown
Contributor Author

Yes, This PR is ready to be merged.

@chimame
Copy link
Copy Markdown
Contributor

chimame commented Feb 11, 2024

@shossk

Thank you for writing your thoughts. I certainly think your opinion is correct.
I think they are giving their opinions on how precisely to express it.
I don't see that much of a problem as it is still correct as Japanese. Do you really want to change things as they are now?

考えを書いてくれてありがとう。確かに書いてくれた意見も正しいと思っています。
どこまで厳密に表すかということに意見をくれていると思っています。
私は今のままでも日本語として正しいものになっているのでそこまで問題を感じていません。今のままではどうしても変更したいですか?

@shossk
Copy link
Copy Markdown

shossk commented Feb 11, 2024

@chimame
No problem!
I wish you a nice PR! :)

@fabian-hiller
Copy link
Copy Markdown
Member

Thank you all!

@fabian-hiller fabian-hiller merged commit 0e66509 into open-circle:main Feb 11, 2024
@roottool roottool deleted the feat-i18n-ja branch February 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants