Skip to content

Add NET 5 and NET Core 3.1 support.#16

Merged
augustoproiete merged 2 commits intoookii-dialogs:masterfrom
VPKSoft:master
Feb 15, 2021
Merged

Add NET 5 and NET Core 3.1 support.#16
augustoproiete merged 2 commits intoookii-dialogs:masterfrom
VPKSoft:master

Conversation

@VPKSoft
Copy link
Copy Markdown
Contributor

@VPKSoft VPKSoft commented Feb 10, 2021 •
edited
Loading

The demo seems to work targeting with NET 5. Some of the fancy versioning and build scripts may brake with the assembly info modifications.

The project format is changed to the new SDK format:

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <ProductVersion>9.0.30729</ProductVersion>
    <OutputType>WinExe</OutputType>
    <!--<TargetFramework>net45</TargetFramework>-->
    <!--<TargetFramework>netcoreapp3.1</TargetFramework>-->
    <TargetFramework>net5.0-windows</TargetFramework>
    <ApplicationManifest>app.manifest</ApplicationManifest>
    <ApplicationIcon>ookii.ico</ApplicationIcon>
    <AssemblyTitle>Ookii.Dialogs.WinForms.Sample</AssemblyTitle>
    <Company>augustoproiete.net</Company>
    <Product>Ookii.Dialogs.WinForms</Product>
    <Copyright>Copyright (c) 2009-2021 Ookii Dialogs Contributors</Copyright>
    <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>

Just uncomment the other target and comment the other. The NuGet is targeting all the three different ones. 🙂

augustoproiete
augustoproiete requested changes Feb 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VPKSoft Thanks a lot for submitting this! Overall looks good. I've added some minor comments if you have a chance to go through, otherwise I can do after merging.

I should be able to do a proper review/test over the weekend and hopefully get this merged asap.

One important question: Are you able to edit the forms using the Visual Studio designer and .resx files normally in VS2019 after this PR?

What happens if you make a change to a form? Does the code-behind get generated correctly?

@augustoproiete augustoproiete added the enhancement New feature or request label Feb 10, 2021
@augustoproiete augustoproiete added this to the 2.0.0 milestone Feb 10, 2021
@VPKSoft
Copy link
Copy Markdown
Contributor Author

VPKSoft commented Feb 10, 2021

Hi,
The forms seem to be editable with the NET 5 config:
image
It says changes have happened, but actually nothing has changed:
image
I'll have a look at your suggestions tomorrow and make the necessary edits. 👍

This was linked to issues Feb 10, 2021
Add support for .NET Core 3.1 #7
Closed
Add support for .NET 5 #8
Closed
@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Feb 10, 2021

Awesome! Thanks again 🎉

@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Feb 15, 2021

Thanks @VPKSoft I was able to do some tests over the weekend, and looks good.

There's a couple of things that need to be ironed out before a release, but I'm happy to merge it as-is for now and continue improving in future commits/PRs.

As you pointed out, the build script is now broken because it tries to update the AssemblyVersionInfo.cs which you renamed so it can no longer find it. The final solution will be to get the build script closer to the one that ookii-dialogs-wpf is using where the version is passed to DotNetCoreBuild.

There's also a number of warnings that need to be resolved (most of them cause by .NET 5):

Build warnings (click to expand) 

"C:\ookii-dialogs-winforms\Ookii.Dialogs.WinForms.sln" (Rebuild target) (1) ->
"C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj" (Rebuild target) (2) ->
"C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj" (Build target) (2:7) ->
(CoreCompile target) -> 
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(25,6): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(25,25): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(94,10): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(94,30): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(94,63): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(33,10): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(33,30): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(33,63): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(41,6): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(41,25): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(61,6): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\SafeHandles.cs(61,25): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\ExtendedForm.cs(285,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\ExtendedForm.cs(285,57): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\ExtendedForm.cs(285,120): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(58,9): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(58,29): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(58,62): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(228,37): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(228,57): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(228,90): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(397,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(397,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(397,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(438,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(438,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(438,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(512,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(512,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(512,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(34,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(34,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(34,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(44,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(44,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(44,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(54,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(54,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(54,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(65,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(65,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(65,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(506,10): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(506,30): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(506,63): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(76,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(76,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(76,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(87,10): warning SYSLIB0003: 'SecurityPermissionAttribute' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(87,29): warning SYSLIB0003: 'SecurityAction' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialException.cs(87,64): warning SYSLIB0003: 'SecurityPermissionFlag' is obsolete: 'Code Access Security is not supported or honored by the runtime.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(510,10): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(510,30): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(510,63): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(756,37): warning SYSLIB0004: 'ReliabilityContractAttribute' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(756,57): warning SYSLIB0004: 'Consistency' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\NativeMethods.cs(756,90): warning SYSLIB0004: 'Cer' is obsolete: 'The Constrained Execution Region (CER) feature is not supported.' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\CredentialDialog.cs(468,34): warning CS8073: The result of the expression is always 'false' since a value of type 'IntPtr' is never equal to 'null' of type 'IntPtr?' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]
  C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\ProgressDialog.cs(564,31): warning CS8073: The result of the expression is always 'false' since a value of type 'IntPtr' is never equal to 'null' of type 'IntPtr?' [C:\ookii-dialogs-winforms\src\Ookii.Dialogs.WinForms\Ookii.Dialogs.WinForms.csproj]

If you fancy sending PRs to fix the above feel free, if not I'll get to them at some point in the next week or two, no worries.

augustoproiete
augustoproiete approved these changes Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@augustoproiete augustoproiete merged commit 200ab4a into ookii-dialogs:master Feb 15, 2021
@augustoproiete
Copy link
Copy Markdown
Member

augustoproiete commented Feb 15, 2021

@VPKSoft your changes have been merged, thanks for your contribution 👍

@VPKSoft
Copy link
Copy Markdown
Contributor Author

VPKSoft commented Feb 15, 2021

I might create another PR if I have the time. I'm currently converting my own packages and probably need to publish few NuGets from repositories created by others, which are not maintained anymore. Just prefix the package with unofficial. 🙂 But great that this is progressing - the WinForms basic folder browser dialog just is quite unusable 👍

@augustoproiete augustoproiete modified the milestones: 2.0.0, 3.0.0 Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees

@VPKSoft VPKSoft

Labels

enhancement New feature or request

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Add support for .NET 5 Add support for .NET Core 3.1

2 participants

@VPKSoft @augustoproiete