Add support for MultiLine field on InputDialog#11
Merged
augustoproiete merged 1 commit intoookii-dialogs:masterfrom Nov 24, 2020
Merged
Add support for MultiLine field on InputDialog#11augustoproiete merged 1 commit intoookii-dialogs:masterfrom
augustoproiete merged 1 commit intoookii-dialogs:masterfrom
Conversation
Contributor
Author
|
This is my first PR ever, any feedback is appreciated |
Member
|
Thank you @junior-ramone and congrats on your first PR! 🎉 🇧🇷 Overall looks good and I'll be able to actually run the PR tomorrow night after work, but will add a comment or two in the meantime. |
augustoproiete
requested changes
Nov 23, 2020
Contributor
Author
|
Hi, thanks for your feedback. I've made the requested changes and pushed. Do I have to create a new pull request? |
Member
|
Thanks @junior-ramone! No need for another PR. You're all set. I'll get this merged in a bit! |
103a6f7 to
ba3e2dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #3