Dev ms#3232
Closed
unixwzrd wants to merge 4 commits intooobabooga:mainfrom
unixwzrd:dev-ms
Closed
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating performance issues, discovered that ElevenLabs and Silero TTS are using the global model variable and clobbering it.
Also, changed the filename of the ElevenLabs output audio to match the name of the one produced by Silero, since the names as just sequence numbers were causing problems in some web browsers as it assumed the file was cached locally.
This also improves performance for macOS as using Silero will cause torch to switch torch devices and fall back to CPU instead of leaving model alone for the inference model. This will likely make some Mac users happy.