Include line separator when reading queries from Jar resources.#1247
Merged
jamesaoverton merged 1 commit intoontodev:masterfrom Mar 7, 2025
Merged
Conversation
When we read a default query string from a resource embedded within the Jar file, make sure to explicitly include a line separator between each line (the line terminator is *not* included in the value returned by BufferedReader#readLine()). Otherwise the entire query is stored as a single line, which prevents its from being analyzed correctly by the SPARQL parser.
Member
|
This one is horrifying. I'm amazed it didn't cause a bigger problem. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves [#1212]
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedWhen we read a default query string from a resource embedded within the Jar file, we need to make sure to explicitly include a line separator between each line (the line terminator is not included in the value returned by
BufferedReader#readLine()). Otherwise the entire query is stored as a single line, which prevents its from being analyzed correctly by the SPARQL parser.