Merged
Conversation
balhoff
approved these changes
Mar 12, 2024
Contributor
balhoff
left a comment
There was a problem hiding this comment.
Looks good, but I had two questions.
jamesaoverton
requested changes
May 1, 2024
robot-command/src/main/java/org/obolibrary/robot/RelaxCommand.java
Outdated
Show resolved
Hide resolved
jamesaoverton
approved these changes
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1060, #1183
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThese PR extends the relax command by adding three new options:
--exclude-named-classes: if true, A EquivalentTo B between named classes are excluded fromrelax--include-subclass-of: if true,A Subclass A and R some Bisrelaxedthe same way asA EquivalentTo A and R some B, see @cmungall request in relax is currently incomplete #1183--enforce-obo-format: If true, only simple existentials and named subsumptions are asserted during the processI like all the functionality, but the
--enforce-obo-formatis really clunky. I would be happy if someone made a better suggestion; I also dont like--exclude-nested.The only "breaking" change in this PR is that the CLI gets
--exclude-named-classesby default astrue. Previously, before this option existed, A=B was relaxed to A sub B and B sub A. No one I personally now has ever said that this is a good idea, so we changed the default, as discussed in #1060.