Extend RelatedObjectsHelper.getAxiomSubjects() to missing property axiom types#1187
Merged
jamesaoverton merged 8 commits intomasterfrom May 1, 2024
Merged
Conversation
balhoff
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1108
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis PR ensures that Property axioms are taken into account correctly when determining
baseaxioms. This is achieved by adding special treatment to a number of property axioms toRelatedObjectsHelper.getAxiomSubjects(), which is responsible to determine which entity is the "subject" of an axiom, which in turn is used by the methods to determine base-iris. For example TransitiveProperty(?p) was previously not considered about ?p - now it is.I have tested the approach extensively with RO. The changed tests as part of this PR reflect the new behaviour correctly.