Skip to content

Documenting merge-axiom-annotation on repair command#1103

Closed
cmungall wants to merge 1 commit intomasterfrom
cmungall-patch-1
Closed

Documenting merge-axiom-annotation on repair command#1103
cmungall wants to merge 1 commit intomasterfrom
cmungall-patch-1

Conversation

@cmungall
Copy link
Contributor

See also

Note this is purely a documentation change so I deleted the PR checklist. Ideally this would have an example but I wanted to get something out while I had the chance


An example of this scenario is an ontology such as UBERON that provides provenance on synonyms as axiom annotations. A single class such as UBERON:0002103 (hindlimb) may have two synonym axioms both with the value "membrum inferius", the first having provenance from FMA, the second from Wikipedia. The Uberon editors may wish to merge these into a single axiom, with two provenance annotations.

Running `repair` with `--merge-axiom-annotations` will merge these structurally indistinguishable axioms into a single axiom, and combine all annotations together.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work as expected, see #1099 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this PR as a draft until this issue is resolved.

@jamesaoverton jamesaoverton marked this pull request as draft September 20, 2023 16:07
@jamesaoverton
Copy link
Member

Please reopen if you still want this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants