Add configuration parameter for automatically sending an initial response #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+275
to
+281
|
|
||
| /** | ||
| * If true, a first provisional response after the 100 Trying will be sent automatically if UAC does not | ||
| * require reliable provisional responses. | ||
| * @defaultValue `true` | ||
| */ | ||
| sendInitialProvisionalResponse?: boolean; |
Collaborator
There was a problem hiding this comment.
Please match style by adding this new option in alphabetical order - thanks.
john-e-riordan
requested changes
Jan 20, 2021
| userAgentString: "SIP.js/" + LIBRARY_VERSION, | ||
| viaHost: "" | ||
| viaHost: "", | ||
| sendInitialProvisionalResponse: true |
Collaborator
There was a problem hiding this comment.
Please match style by adding this new option in alphabetical order - thanks.
Collaborator
|
Other than the suggested changes to matching style, looks good to me. |
Collaborator
|
Oh - docs will need to be re-generated. |
Collaborator
|
Thanks again! I'll make the suggested changes in a follow-up commit now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #865.
Adds a configuration parameter to allow turning off automatically sending provisional responses. Defaults to current behaviour.