Skip to content

Fixing ONNX Debug mode on Windows, adding ONNX Debug CI for Windows#2605

Closed
vinitra-zz wants to merge 51 commits intoonnx:masterfrom
vinitra-zz:ci-dev-build
Closed

Fixing ONNX Debug mode on Windows, adding ONNX Debug CI for Windows#2605
vinitra-zz wants to merge 51 commits intoonnx:masterfrom
vinitra-zz:ci-dev-build

Conversation

@vinitra-zz
Copy link
Copy Markdown

@vinitra-zz vinitra-zz commented Feb 15, 2020 •
edited
Loading

To resolve #1880, install onnx from source in CI w/ Debug mode for Windows. Linux / Mac builds are in #2651.

@vinitra-zz vinitra-zz requested a review from a team as a code owner February 15, 2020 00:18
@vinitra-zz
Copy link
Copy Markdown
Author

vinitra-zz commented Feb 15, 2020 •
edited
Loading

Looks like the new debug mode CI build passed in Travis -- @linkerzhang?

bddppq
bddppq reviewed Feb 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a debug build with ONNX_ML on?

Comment thread .travis.yml Outdated
@prasanthpul prasanthpul added the topic: build Issues related to ONNX builds and packages label Feb 15, 2020
@linkerzhang
Copy link
Copy Markdown
Member

linkerzhang commented Feb 16, 2020

Looks like the new debug mode CI build passed in Travis -- @linkerzhang?

will you also cover it in windows ci?

@vinitra-zz
Copy link
Copy Markdown
Author

vinitra-zz commented Feb 18, 2020 •
edited
Loading

Looks like the new debug mode CI build passed in Travis -- @linkerzhang?

will you also cover it in windows ci?

Added windows build into Appveyor and onnx-ml linux build into Travis.

@vinitra-zz
Copy link
Copy Markdown
Author

vinitra-zz commented Feb 19, 2020

Seeing this error in the Debug build for Windows.

gtest.lib(gtest-all.obj) : error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in test_driver.obj [C:\projects\onnx\.setuptools-cmake-build\onnxifi_test_driver_gtests.vcxproj]

gtest.lib(gtest-all.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in test_driver.obj [C:\projects\onnx\.setuptools-cmake-build\onnxifi_test_driver_gtests.vcxproj]

Looks like a discrepancy between debug and release builds in DLLs. Investigating.

@vinitra-zz vinitra-zz changed the title Adding CI for ONNX Debug mode Fixing ONNX Debug mode on Windows, adding ONNX Debug CI Feb 19, 2020
@vinitra-zz vinitra-zz changed the title Fixing ONNX Debug mode on Windows, adding ONNX Debug CI [1.7 release] [1.7 release] Fixing ONNX Debug mode on Windows, adding ONNX Debug CI Feb 26, 2020
@vinitra-zz vinitra-zz requested a review from a team as a code owner February 28, 2020 22:25
@vinitra-zz vinitra-zz changed the title [1.7 release] Fixing ONNX Debug mode on Windows, adding ONNX Debug CI Fixing ONNX Debug mode on Windows, adding ONNX Debug CI Feb 28, 2020
@postrational
Copy link
Copy Markdown
Contributor

postrational commented Mar 2, 2020

Looks like there are some merge artifacts on this branch currently.

@vinitra-zz vinitra-zz mentioned this pull request Mar 10, 2020
Merged
@vinitra-zz vinitra-zz changed the title Fixing ONNX Debug mode on Windows, adding ONNX Debug CI Fixing ONNX Debug mode on Windows, adding ONNX Debug CI for Windows Mar 10, 2020
@vinitra-zz vinitra-zz closed this Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wschin wschin wschin left review comments

@linkerzhang linkerzhang Awaiting requested review from linkerzhang

+1 more reviewer

@bddppq bddppq bddppq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: build Issues related to ONNX builds and packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

At least one CI build and install ONNX in debug mode

7 participants

@vinitra-zz @linkerzhang @postrational @wschin @bddppq @prasanthpul @vinitra