Skip to content

Introduce MeanSquaredError and SoftmaxCrossEntropy as Loss Function#1939

Closed
SherlockNoMad wants to merge 89 commits intoonnx:masterfrom
SherlockNoMad:bahuang/loss_func
Closed

Introduce MeanSquaredError and SoftmaxCrossEntropy as Loss Function#1939
SherlockNoMad wants to merge 89 commits intoonnx:masterfrom
SherlockNoMad:bahuang/loss_func

Conversation

@SherlockNoMad
Copy link
Copy Markdown
Contributor

@SherlockNoMad SherlockNoMad commented Apr 16, 2019

This PR is a part of ONNX training spec. If you want to see all components in the training spec proposal, please see #2314

@SherlockNoMad SherlockNoMad requested a review from a team as a code owner April 16, 2019 06:20
@SherlockNoMad SherlockNoMad changed the title Introduce MeanSquaredError as Loss Function Introduce MeanSquaredError and SoftmaxCrossEntropy as Loss Function Apr 22, 2019
Comment thread onnx/defs/loss/defs.cc Outdated
Comment thread onnx/defs/loss/defs.cc Outdated
Comment thread onnx/defs/loss/defs.cc
Comment thread onnx/defs/loss/defs.cc Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 24, 2019

CLA assistant check
All committers have signed the CLA.

@postrational postrational added the topic: operator Issues related to ONNX operators label Aug 23, 2019
@wschin wschin requested a review from a team as a code owner September 17, 2019 06:29
@prasanthpul prasanthpul added this to the 1.7 milestone Sep 17, 2019
@postrational postrational added the topic: training Issues related to ONNX training label Oct 16, 2019
Copy link
Copy Markdown
Contributor

@postrational postrational left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for MeanSquaredError and SoftmaxCrossEntropy.
Please clean up this PR, so it contains files related only to MeanSquaredError and SoftmaxCrossEntropy.

@wschin
Copy link
Copy Markdown
Collaborator

wschin commented Feb 18, 2020

We have a replacement for this PR, so please allow me to close the PR.
#2573
#2570

@wschin wschin closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: operator Issues related to ONNX operators topic: training Issues related to ONNX training

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants