Introduce MeanSquaredError and SoftmaxCrossEntropy as Loss Function#1939
Closed
SherlockNoMad wants to merge 89 commits intoonnx:masterfrom
Closed
Introduce MeanSquaredError and SoftmaxCrossEntropy as Loss Function#1939SherlockNoMad wants to merge 89 commits intoonnx:masterfrom
SherlockNoMad wants to merge 89 commits intoonnx:masterfrom
Conversation
wschin
reviewed
Apr 22, 2019
wschin
reviewed
Apr 22, 2019
wschin
reviewed
Apr 22, 2019
wschin
reviewed
Apr 22, 2019
Fix Update other docs
Remove copied Add momentum Save Remove momentum Fix Move constants to attributes
Update docs
Add two node tests Update test coverage
postrational
requested changes
Nov 4, 2019
Contributor
postrational
left a comment
There was a problem hiding this comment.
Please add unit tests for MeanSquaredError and SoftmaxCrossEntropy.
Please clean up this PR, so it contains files related only to MeanSquaredError and SoftmaxCrossEntropy.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of ONNX training spec. If you want to see all components in the training spec proposal, please see #2314