allow removed experimental ops in the checker for now (#1792)

houseroad · web-flow · commit 822d8df0a2a3 · 2019-02-05T20:42:10.000-08:00
diff --git a/onnx/checker.cc b/onnx/checker.cc
@@ -319,6 +319,15 @@ void check_node(
         ") has zero input and zero output.");
   }
 
+  // Put the removed experimental ops here
+  if (node.op_type() == "ConstantFill") {
+    std::cerr << "Warning: " << node.op_type() << " was a removed "
+      << " experimental ops. In the future, we may directly "
+      << "reject this operator. Please update your model as soon "
+      << "as possible.";
+    return;
+  }
+
   // Resolve domain for node
   const auto& opset_imports = ctx.get_opset_imports();
   auto dit = opset_imports.find(node.domain());
diff --git a/onnx/test/checker_test.py b/onnx/test/checker_test.py
@@ -231,6 +231,11 @@ def test_check_tensor_zero_elem(self):  # type: () -> None
         tensor = self._sample_0_elem_tensor
         checker.check_tensor(tensor)
 
+    def test_check_removed_experimental_op(self):  # type: () -> None
+        node = helper.make_node(
+            "ConstantFill", [], ["Y"], name="test", shape=[1, 2])
+        checker.check_node(node)
+
 
 if __name__ == '__main__':
     unittest.main()
