Fix Unique unit test (#2381)

skottmckay · houseroad · commit 2891e1459745 · 2019-10-04T14:20:54.000-07:00
* Fix Unique unit test

Expected data for Y was incorrectly sorted

* Update test coverage documentation

* Update Operators.md
diff --git a/docs/Operators.md b/docs/Operators.md
@@ -18396,8 +18396,8 @@ y, indices, inverse_indices, counts = np.unique(x, True, True, True)
 argsorted_indices = np.argsort(indices)
 inverse_indices_map = {i: si for i, si in zip(argsorted_indices, np.arange(len(argsorted_indices)))}
 
-y = np.take(x, indices, axis=0)
 indices = indices[argsorted_indices]
+y = np.take(x, indices, axis=0)
 inverse_indices = np.asarray([inverse_indices_map[i] for i in inverse_indices], dtype=np.int64)
 counts = counts[argsorted_indices]
 # print(y)
diff --git a/docs/TestCoverage.md b/docs/TestCoverage.md
@@ -10233,8 +10233,8 @@ y, indices, inverse_indices, counts = np.unique(x, True, True, True)
 argsorted_indices = np.argsort(indices)
 inverse_indices_map = {i: si for i, si in zip(argsorted_indices, np.arange(len(argsorted_indices)))}
 
-y = np.take(x, indices, axis=0)
 indices = indices[argsorted_indices]
+y = np.take(x, indices, axis=0)
 inverse_indices = np.asarray([inverse_indices_map[i] for i in inverse_indices], dtype=np.int64)
 counts = counts[argsorted_indices]
 # print(y)
diff --git a/onnx/backend/test/case/node/unique.py b/onnx/backend/test/case/node/unique.py
@@ -42,8 +42,8 @@ def export_not_sorted_without_axis():  # type: () -> None
         argsorted_indices = np.argsort(indices)
         inverse_indices_map = {i: si for i, si in zip(argsorted_indices, np.arange(len(argsorted_indices)))}
 
-        y = np.take(x, indices, axis=0)
         indices = indices[argsorted_indices]
+        y = np.take(x, indices, axis=0)
         inverse_indices = np.asarray([inverse_indices_map[i] for i in inverse_indices], dtype=np.int64)
         counts = counts[argsorted_indices]
         # print(y)
diff --git a/onnx/backend/test/data/node/test_unique_not_sorted_without_axis/test_data_set_0/output_0.pb b/onnx/backend/test/data/node/test_unique_not_sorted_without_axis/test_data_set_0/output_0.pb
