Rename sample_weight to w (code quality)#1457
Merged
MaxHalford merged 7 commits intoNov 23, 2023
Merged
Conversation
Signed-off-by: mariliatd <mariliatd@gmail.com>
Signed-off-by: mariliatd <mariliatd@gmail.com>
Signed-off-by: mariliatd <mariliatd@gmail.com>
Signed-off-by: mariliatd <mariliatd@gmail.com>
Signed-off-by: mariliatd <mariliatd@gmail.com>
Signed-off-by: mariliatd <mariliatd@gmail.com>
MaxHalford
requested changes
Nov 22, 2023
MaxHalford
left a comment
Member
There was a problem hiding this comment.
Great!
Can you add a note to unreleased.md? This is a breaking change so it's important to list it in the release notes.
Signed-off-by: mariliatd <mariliatd@gmail.com>
Contributor
Author
|
Notes added to |
Contributor
|
@mariliatd Thank you very much for making the changes! I don't have anything to add, so it now is all comes down to @MaxHalford to finalize on this PR! |
Member
|
Thanks @mariliatd :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is related to issue #1418.