Fix issue #129 by rewriting the ARC handler yara rule.#130
Merged
Conversation
4eae512 to
da44f1b
Compare
Contributor
Author
|
I added two enhancements to ARC handler that will help with #129. Moved the size to an unsigned integer (should always be positive), and added a name validation function that verify if the file name is unicode encoded. |
vlaci
requested changes
Jan 4, 2022
da44f1b to
3ec5b99
Compare
Contributor
|
Hm, a file doesn't get extracted now :( |
Contributor
|
From the docstring of the yara rule:
This matches with the output of the test:
This will trip on the |
3ec5b99 to
9097c90
Compare
Contributor
Author
|
Fixed # we don't care about the terminating byte (null or unitialized)
snull(name[:-1]).decode("utf-8") |
Contributor
|
Yaay, null bytes are valid unicode code points :D |
vlaci
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #129