fix(one): run +not-found middleware for static-looking probes#712
Merged
Conversation
|
🚅 Deployed to the one-pr-712 environment in onestack.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/middleware.test.ts > Middleware > middleware runs even on not found routes) was caused by the previous +not-found static-probe shortcut bailing tonullbefore middleware ran.runMiddlewaresfirst when the matched +not-found has middleware — middleware can intercept (e.g. JSON 404), otherwise we return a bare 404 instead of SSR'ing the not-found page.return nullpath so the unit test for sourcemap probes is unaffected.Test plan
packages/onevitest passes (20/20 in createHandleRequest, 518/574 overall)tests/testdev + prod suites green (the integration middleware test was the failure)