Fixed a problem under wp 3.4.2#18
Merged
thom4parisot merged 1 commit intothom4parisot:masterfrom Nov 12, 2012
Merged
Conversation
Owner
|
I think it was an inevitable move. Some themes (like reported here http://wordpress.org/support/topic/plugin-wp-less-wp-34) enqueue their stuff at the latest moment. I usually register stylesheets etc. on Anyway, I feel it's safer to postpone to the latest moment possible the compilation process, agreed. |
thom4parisot
pushed a commit
that referenced
this pull request
Nov 12, 2012
Fixed a problem under wp 3.4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found there's a serious problem that it doesn't work under the new version of wordpress.
The hook should better to attached on 'wp_enqueue_scripts' than just 'wp', which will set the plugin to process before everything, and the queueing of scripts and stylesheets by theme is not done yet at the time.
Didn't test on older versions of wordpress, but those shall work as will.