Refactor for readability in #identity method in OmniAuth::Strategies::Identity#123
Merged
pboling merged 1 commit intoSep 18, 2024
Conversation
Member
|
@Xeragus Released in v3.1.0 and v3.1.1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves readability of the
identitymethod inOmniAuth::Strategies::Identityconditions.to_hashis redundant, sinceto_hashdoesn't change the caller, and the return of that call is never stored anywhereoptions[:locate_conditions]three times, it is now stored in a variable that is used below, which in turn allows for a ternary operator instead of anif-else