Skip to content

Replace deprecated usage of Request[] with request.params[]#116

Closed
adolski wants to merge 1 commit into
omniauth:masterfrom
medusa-project:master
Closed

Replace deprecated usage of Request[] with request.params[]#116
adolski wants to merge 1 commit into
omniauth:masterfrom
medusa-project:master

Conversation

@adolski

@adolski adolski commented Dec 14, 2023

Copy link
Copy Markdown

In Rack 3.0.0.beta1, Request[] was deprecated and prints the following message to the console when used:

Request#[] is deprecated and will be removed in a future version of Rack. Please use request.params[] instead

This PR replaces the use of Request[] with Request.params[] per the recommendation of the console message.

@scott8803

Copy link
Copy Markdown

Any idea if this is going to be merged in? Is this gem still maintained by anyone?

@scott8803

Copy link
Copy Markdown

Who has write access to this repository to merge in the changes above? This completely crashes now in Rails 7/Rack 3.1 without it.

@pboling

pboling commented Sep 18, 2024

Copy link
Copy Markdown
Member

Sorry I missed the notifications here. I'll get a new release out this week.

Are you able to rebase on latest master?

@adolski

adolski commented Sep 20, 2024

Copy link
Copy Markdown
Author

@pboling I'm sorry, I don't have access to this repo anymore. But I think you could merge #122 instead (once conflicts are resolved).

@pboling

pboling commented Sep 20, 2024

Copy link
Copy Markdown
Member

Closing in favor of #122

@pboling pboling closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants