Humanize messages that will be displayed on a user's screen#49
Merged
Humanize messages that will be displayed on a user's screen#49
Conversation
00f6fe3 to
158e520
Compare
32d72e1 to
f786ff7
Compare
…lear & understanable, no more robot message.
…has been created.
f786ff7 to
a332173
Compare
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
Because currently messages in the plugin kinda robot-ish, it can tell what is going on, but not enough to helping user to diagnose issues that has been raised on their screen by themselves.
For example, a payment result validation at the 3-D Secure callback function.
This one is almost good, but can be better. 'Order not found'.
As a programmatic, it does make senses because this error will be raised if a method cannot retrieve an order object from a given
order id.But as a user, it tells nothing except something is wrong.
We can humanize it more by the following message.
2. Description of change
2.1. Enhance all messages in the plugin
2.2. Translate all of messages into JA, ID.
2.3. Add Grunt.js task. (now you can use 'grunt makepot' to build a 'pot' file.)
3. Quality assurance
✏️ Details:
It's mostly about word, sentence, message.
In order to check, you can look at https://github.com/omise/omise-woocommerce/blob/a332173499d4f098dea0cb8068366de8a5de8a57/languages/omise-ja.po
4. Impact of the change
No.
5. Priority of change
Normal
6. Additional Notes
There are some parts that haven't been translated left but it's my intention. I want to test translate with GlotPress.