Merged
Conversation
AnasNaouchi
previously approved these changes
Nov 11, 2024
new4762
previously approved these changes
Nov 11, 2024
d114d9e
new4762
approved these changes
Nov 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bank lists is empty and throwing error in Duitnow OBW.
On the last change, we removed the bank list and tried to get the list of banks from capabilities. But since we had restriction on where capabilities API can be called to reduce the number of calls of capabilites API, the banks list were not fetched. I have reverted the change and added the bank list back to resolve the issue. In the future, we will improve this to fetch the bank list dynamically from capabilities again.
Rollback procedure
default rollback procedure