Fixed Japanese translation issue in secure form.#389
Merged
aashishgurung merged 2 commits intodevelopfrom Aug 4, 2023
Merged
Conversation
ajzkk
reviewed
Aug 4, 2023
ajzkk
approved these changes
Aug 4, 2023
Contributor
|
@aashishgurung no tests? |
Contributor
Author
|
@danfowler We discussed that writing test cases for our current JS implementation is challenging and decided to not include them. That's why our sonar cloud setup also excludes JS. |
danfowler
approved these changes
Aug 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
Fix Japanese translation issue in secure form.
2. Description of change
We removed the
localMatchingarray which was not necessary. because we get the required value from the LOCALE.3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments: