Skip to content

[ENGA3-1134]: Installment minimum amount#365

Merged
aashishgurung merged 6 commits intodevelopfrom
feature/ENGA3-1134-installment-minimum-amount
Apr 17, 2023
Merged

[ENGA3-1134]: Installment minimum amount#365
aashishgurung merged 6 commits intodevelopfrom
feature/ENGA3-1134-installment-minimum-amount

Conversation

@aashishgurung
Copy link
Copy Markdown
Contributor

1. Objective

Fetch the minimum amount of Installment payment method from live config of the Opn account.

Jira Ticket: #1134

2. Description of change

Updated the Omise PHP to use minimum amount from the capability API instead of pre-defined value. Added a function getInstallmentMinLimits in includes/class-omise-capabilities.php to get the minimum amount to show it in the checkout page.

Screenshot 2566-04-10 at 11 02 38

3. Quality assurance

  • Updated the minimum installment amount value from the Opn configuration

  • Enable Installment payment method in WooCommerce.

  • Add items to the cart but below the installment amount value you set up on the Opn config.

  • You should see above screenshot.

  • Add items to the cart above the installment amount value you set up on the Opn config.

  • You should see a list of banks.

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 5.0.0

@aashishgurung aashishgurung requested a review from danfowler April 10, 2023 04:33
@aashishgurung aashishgurung requested a review from ajzkk as a code owner April 10, 2023 04:33
@aashishgurung aashishgurung changed the base branch from develop to master April 12, 2023 09:44
@aashishgurung aashishgurung changed the base branch from master to develop April 12, 2023 09:44
ajzkk
ajzkk previously approved these changes Apr 12, 2023
Comment thread includes/gateway/class-omise-payment-installment.php Outdated
Comment thread includes/gateway/class-omise-payment-installment.php Outdated
Comment thread includes/libraries/omise-php/lib/omise/OmiseCapabilities.php Outdated
@aashishgurung aashishgurung merged commit 8530b7a into develop Apr 17, 2023
@aashishgurung aashishgurung deleted the feature/ENGA3-1134-installment-minimum-amount branch May 3, 2023 10:16
@ajzkk ajzkk mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants