[ENGA3-553]: Increased the delay to 2 seconds and added a check for OCBC PAO redirect URL.#327
Merged
aashishgurung merged 3 commits intomasterfrom Nov 1, 2022
Merged
Conversation
…CBC PAO redirect URL.
ajzkk
approved these changes
Nov 1, 2022
Contributor
ajzkk
left a comment
There was a problem hiding this comment.
You can also use sleep(2) instead of usleep(2000000)
…ry params in redirect URI now. Also implemented polling for delay.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
Increased the delay to 2 seconds.
Jira Ticekt: #553
2. Description of change
We observed 0.5 secs was not enough sometimes with RMS payment method while testing with Shopify. To be on safe side, we increase delay to 2 secs. Plus, we added a check for OCBC PAO redirect URL so that plugin won't identity it as user originated request because we can't add query params in OCBC PAO.
3. Quality assurance
🔧 Environments: