[ENGA3-421]: Billing address details are removed from the POST data when creating card token.#304
Merged
aashishgurung merged 3 commits intomasterfrom Sep 6, 2022
Merged
Conversation
…hen creating card token.
new4762
approved these changes
Sep 5, 2022
Contributor
new4762
left a comment
There was a problem hiding this comment.
😿 hope we find alternative solution soon
ajzkk
approved these changes
Sep 5, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
kan98
approved these changes
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
Billing address details were added to create a card token in
omise-payment-form-handler.jsbecause Visa backend requires billing address (Reference: #269). It has been removed because this caused issue on some merchants because some sell digital products so they won't have billing address. Some merchants customize the checkout page so the billing address may not have the same IDs we were expecting. This caused issue ofundefienderror.Even though we fix the
undefinederror to meaningful error, it will still cause issue as they won't have the billing address or a customize billing address fields.Jira Ticket: #421
2. Description of change
Billing address details have been removed from the POST data when creating card token in
omise-payment-form-handler.js.3. Quality assurance
Checkout without filling billing address. You should see default Woocommerce error instead of
undefinederror.🔧 Environments: