Add Bank of China Logo for FPX#274
Merged
jutinapas merged 7 commits intoapm2-695-update-fpx-displayfrom May 24, 2022
Merged
Conversation
kan98
approved these changes
May 20, 2022
Contributor
kan98
left a comment
There was a problem hiding this comment.
can you add a screenshot to the PR showing the new bank in the list? thanks!
hpariwat
approved these changes
May 20, 2022
tookaa2
approved these changes
May 20, 2022
aashishgurung
approved these changes
May 23, 2022
new4762
approved these changes
May 23, 2022
FhanOmise
approved these changes
May 23, 2022
new4762
approved these changes
May 24, 2022
This reverts commit 484e1a0.
kan98
approved these changes
May 24, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
According to https://www.omise.co/which-banks-in-malaysia-support-fpx, the Bank of China (Malaysia) Berhad is not yet supported in the FPX payment method.
2. Description of change
Add the logo of Bank of China (Malaysia) Berhad to the FPX bank support list.